Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#2413 closed bug (Fixed)

Add torrent from link doesn't work with split client/server

Reported by: Se7enLC Owned by:
Priority: minor Milestone: 1.3.8
Component: GTK UI Version: 1.3.6
Keywords: Cc:

Description

If you use deluge in split client/server mode, when you launch it from a magnet URL, it launches deluge, but forgets about the URL you clicked. To add the torrent you need to first launch deluge, then click the URL.

Steps to reproduce: 1). Have a Deluge server running 2). Have Deluge client set up to connect to it 3). Click a Magnet URL

Expected results:

  • Deluge launches, add dialog opens

Actual results:

  • Deluge launches, nothing added

Change History (15)

comment:2 Changed 7 years ago by Cas

  • Resolution set to WorksForMe
  • Status changed from new to closed

comment:3 Changed 7 years ago by tsume

Hello,

I think this ticket could require further investigation. I found some other reports of users experiencing this issue. An example thread which I replied to is here: http://forum.deluge-torrent.org/viewtopic.php?f=7&t=45107&p=197633#p197633 I also found that when the issue is happening, if I add a 2nd torrent I will then get the "add torrent" popups for both the 1st and 2nd torrent.

The problem has happened to me twice on two different versions and two different PCs (Windows 8/8.1 being the only common thing between them). The issue took months to present itself on each PC. Deleting the Deluge folder in %appdata% fixed the issue in both cases, so I think it might be some kind of corruption or issue happening to the saved settings. Deleting the folder in appdata fixes it so I'm sure it's not a high priority issue, but it is definitely one people may not know how to fix when it happens to them.

comment:4 Changed 7 years ago by tsume

  • Resolution WorksForMe deleted
  • Status changed from closed to reopened

Going to reopen the ticket so dev can see it.

comment:5 Changed 7 years ago by Cas

  • Milestone changed from Future to 1.3.x

comment:6 Changed 6 years ago by Cas

  • Component changed from Console to GTK-UI
  • Status changed from reopened to pending
  • Version changed from other (please specify) to 1.3.6

My first comment still stands, so do you have any logs or further details? I have never seen this issue so I cannot test or even fix it. It is rather odd that deleting the config would fix, however you should test which specific file in the config is causing the issue.

comment:7 Changed 6 years ago by Se7enLC

Good suggestion, tsume! I'm running Gentoo, and I was able to fix the problem by moving .config/deluge aside and reconfiguring from scratch. Something in the config must be getting corrupted.

comment:8 Changed 6 years ago by Cas

Yes there must be an issue in the config but unless someone provides us with more details on how to replicate we cannot fix it!

comment:9 Changed 6 years ago by Se7enLC

I went through the differences between the working and non-working config, and I found the offending line.

In gtkui.conf "autoadd_queued" was set to true in the non-working case, set to false in the working one.

I tested further by

  • restoring my broken configuration
  • clicking a torrent URL
  • noting that deluge opened, but no "Add Torrent" dialog opened.
  • closing deluge
  • editing that one line, changing true to false
  • clicking a URL
  • noting that deluge now opens with an "add torrent" dialog

Additional info:

autoadd_enable is set to false autoadd_location is set to an empty string

If autoadd_queues is false, when you click a torrent, you first get a dialog listing the queued torrents to be added. When you click Add, it opens up the Add Torrents dialog, so you can click Add again.

That first "Add Queued Torrents" dialog has a checkbox labeled "Automatically add torrents on connect". Checking that box will make the first dialog not appear again, skipping directly to the "Add Torrent" dialog, as expected. But as a side-effect of that change, if deluge is not already running when you click a torrent URL, it doesn't open any dialog at all until you click the URL again.

comment:10 Changed 6 years ago by Cas

Many thanks for debugging that, just what we need to look into fixing it :)

comment:11 Changed 6 years ago by Cas

  • Milestone changed from 1.3.x to 1.3.8
  • Resolution set to Fixed
  • Status changed from pending to closed

I have tested this and I believe this is fixed in 1.3.8.

comment:12 Changed 6 years ago by Se7enLC

1.3.6 is the latest version in gentoo portage. I made a local ebuild for 1.3.8 and tested it out, it seems to work for me as well.

comment:13 Changed 6 years ago by Shished

I have this problem in 1.3.11.

When "focus on window when adding torrent" option is disabled, clicking on magnet link does nothing. If this option is enabled and window is closed, clicking on magnet link opens Deluge window but does not open torrent add dialog. It only works correctly if Deluge window was opened before clicking on magnet link.

I'm using Deluge 1.3.11 on openSUSE 13.2 x86_64 with Gnome-Shell 3.14.

Here is traceback:

Unhandled error in Deferred:
Unhandled Error
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/deluge/ui/gtkui/addtorrentdialog.py", line 157, in show
    return self.update_core_config(True, focus)
  File "/usr/lib/python2.7/site-packages/deluge/ui/gtkui/addtorrentdialog.py", line 202, in update_core_config
    return client.core.get_config_values(self.core_keys).addCallback(_on_config_values)
  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 306, in addCallback
    callbackKeywords=kw)
  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 295, in addCallbacks
    self._runCallbacks()
--- <exception caught here> ---
  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 577, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/usr/lib/python2.7/site-packages/deluge/ui/gtkui/addtorrentdialog.py", line 199, in _on_config_values
    self._show(focus)
  File "/usr/lib/python2.7/site-packages/deluge/ui/gtkui/addtorrentdialog.py", line 171, in _show
    if component.get("MainWindow").is_on_active_workspace():
  File "/usr/lib/python2.7/site-packages/deluge/ui/gtkui/mainwindow.py", line 318, in is_on_active_workspace
    active_wksp = win.get_screen().get_active_workspace()
exceptions.AttributeError: 'NoneType' object has no attribute 'get_screen'

comment:14 Changed 6 years ago by Cas

The issue you are reporting is different to this closed and fixed one, please open a new one.

Note: See TracTickets for help on using tickets.