[Plugins] Wont Start or Disable on Windows

[Doadin]

blocklist execute label notifications stats webui suffer the same issue

12:30:58.941 [ERROR   ][deluge.pluginmanagerbase           :75  ] Failed to start plugin: AutoAdd
Traceback: <type 'exceptions.RuntimeError'>: could not create GladeXML object
twisted/internet/defer.py:150:maybeDeferred
deluge\plugins\init.py:27:enable
build\bdist.win32\egg\deluge\plugins\autoadd\gtkui.py:354:enable

12:30:58.943 [DEBUG   ][deluge.pluginmanagerbase           :61  ] Error when disabling plugin AutoAdd: Traceback (most recent call last):
  File "twisted/internet/defer.py", line 306, in addCallbacks
    
  File "twisted/internet/defer.py", line 588, in _runCallbacks
    
  File "deluge\pluginmanagerbase.py", line 185, in on_started_error
    
  File "deluge\pluginmanagerbase.py", line 209, in disable_plugin
    
--- <exception caught here> ---
  File "twisted/internet/defer.py", line 150, in maybeDeferred
    
  File "deluge\plugins\init.py", line 30, in disable
    
  File "build\bdist.win32\egg\deluge\plugins\autoadd\gtkui.py", line 398, in disable
    
  File "deluge\ui\gtkui\pluginmanager.py", line 47, in deregister_hook
    
exceptions.ValueError: list.remove(x): x not in list

[Calum]

Hmm that is odd, not seeing any issue here.

Can you provide more info as a RuntimeError suggest a gtk/glade issue.

[Doadin]

More info as in? Im not sure what would help here.

Edit ran on a different PC and got:

(deluge:2268): libglade-WARNING **: could not find glade file 'c:\program files
(x86)\deluge\deluge-2.0.0.dev1023-py2.7.egg\deluge\plugins\autoadd-1.6-py2.7.egg
\deluge\plugins\autoadd\data\config.glade'
09:42:34.582 [ERROR   ][deluge.pluginmanagerbase           :75  ] Failed to star
t plugin: AutoAdd
Traceback: <type 'exceptions.RuntimeError'>: could not create GladeXML object
twisted/internet/defer.py:150:maybeDeferred
deluge\plugins\init.py:27:enable
build\bdist.win32\egg\deluge\plugins\autoadd\gtkui.py:354:enable

Which is odd because when I navigate there manually I see that file in the egg.

[Doadin]

Going back to ​https://github.com/deluge-torrent/deluge/tree/8326206f873358feae95e19042e766a554db5393 and building from there works. I suspect the commit following that to be the issue as I tried reverting other potentially related commits and the issue was still there. Unfortunatly simple revert isnt so simple. Ill try and test more.

I was only able to revert cleanly the following:

"[GTKUI] Add prefs liststore col for translation"
"[GTKUI] Small refactor prefs remove_page"
"[#2467|GTKUI] Fix prefs tabs sync adding/removing page"
"[Plugins] Replace pkg_resources for abspath and decode path"

Which did not help but as I stated above going back to that commit works fine. Since the commits all build on each other going back to the working code then picking commits doesnt work at least not without changes which would be a lot of work...

I was able to narrow it down to one of these 4 commits:

[Label] Fix common import from parent dir
[Plugins] Update create_plugin script
[Plugins] Replace pkg_resources for abspath and decode path
[#2341] Use common.resource_filename in plugins

I think 3 or 4 is most likely as 1 and 2 is basically irrelevant here. But my working branch has all latest commits except those 4.

Even with this "working" build I also see an error in Notifications Plugin.

11:00:34.913 [ERROR   ][deluge.pluginmanagerbase           :75  ] Failed to start plugin: Notifications
Traceback: <type 'exceptions.ValueError'>: row sequence has wrong length
twisted/internet/defer.py:150:maybeDeferred
deluge\plugins\init.py:27:enable
build\bdist.win32\egg\deluge\plugins\notifications\gtkui.py:271:enable

The rest seem to work just fine.

[Calum]

Is this on Windows? Ah rhetorical as I see win32...

I understand now that the fix I used for #2341 must have an issue on windows that will need investigating. Thanks for narrowing it down :)

[Doadin]

Sorry I cant help more. GL :)

[Calum]

There is obviously a lot more work and testing required for #2341 so in meantime I have reverted the problem commit: [3893d3e2146401]

Can you confirm this fixes the issue?

[Calum]

I have reverted the other commit so should all be back to normal now.

[Doadin]

Yup. All good now.

[Calum]

Milestone renamed