Opened 5 years ago

Closed 4 years ago

Last modified 6 months ago

#3130 closed feature-request (Fixed)

Use another icon name for tray

Reported by: hxssss Owned by:
Priority: minor Milestone: Future
Component: GTK UI Version: 1.3.15
Keywords: tray icon theme Cc:

Description

Please use other tray icon name for better customization and theme settings. https://github.com/bil-elmoussaoui/Hardcode-Tray/issues/460

Attachments (1)

deluge-systray.patch (691 bytes) - added by hxssss 4 years ago.
patch for using theme icon in systray

Download all attachments as: .zip

Change History (11)

comment:1 Changed 5 years ago by Cas

As far as I was aware if the theme has a <app>-panel.png status icon then it will be used e.g. /usr/share/icons/Faenza-Dark/status/24/deluge-panel.png

comment:2 Changed 5 years ago by hxssss

I just created link for icon from your example, run deluge, but still default icon in use. (/usr/share/icons/Papirus/24x24/panel/deluge-panel.svg already exist and not used by deluge)

sudo ln -s /usr/share/icons/Papirus/24x24/panel/deluge-panel.svg /usr/share/icons/Papirus/status/24

comment:3 follow-up: Changed 5 years ago by Cas

Can you test changing the name from deluge to deluge-panel. You can find the file installation location with:

$ locate gtkui/systemtray.py

comment:4 in reply to: ↑ 3 Changed 5 years ago by hxssss

Replying to Cas:

Yes, it work.

In file /usr/lib/python2.7/site-packages/deluge/ui/gtkui/systemtray.py

line 138: self.tray = gtk.status_icon_new_from_icon_name("deluge-panel")

https://imgur.com/a/FzvFR

Last edited 5 years ago by hxssss (previous) (diff)

Changed 4 years ago by hxssss

patch for using theme icon in systray

comment:5 Changed 4 years ago by Cas

Thanks for the patch, would this not break the icon because we are not providing a deluge-panel.png for the hicolour theme? That is why I am cautious about applying this fix as don't want to break it for the rest of our users

We would need to supply this icon for 16, 22 & 24 pixel icons.

Last edited 4 years ago by Cas (previous) (diff)

comment:6 Changed 4 years ago by hxssss

As I understand, yes, you need to add deluge-panel with Context=Status(/hicolor/[16x16]/status). I don't understand much icon themes. I'm use Papirus icon theme and I am orientated to working with it. This theme have necessary icons. https://github.com/bilelmoussaoui/Hardcode-Tray/issues/460

comment:7 Changed 4 years ago by Cas

  • Resolution set to Fixed
  • Status changed from new to closed

Fixed in develop: [fe42fb2c31d87b013]

Fixed in 1.3-stable: [993abbc6a66]

comment:8 Changed 4 years ago by Cas

  • Milestone changed from needs verified to 1.3.16

comment:9 Changed 4 years ago by hxssss

Thank you!

comment:10 Changed 6 months ago by Cas

  • Milestone changed from 1.3.16 to Future

Ticket retargeted after milestone deleted

Note: See TracTickets for help on using tickets.