Opened 4 years ago

Closed 3 years ago

#3348 closed bug (Fixed)

Add peers broken

Reported by: dtristany Owned by:
Priority: major Milestone: 2.0.4
Component: GTK UI Version: 2.0.3
Keywords: peers_tab, port Cc:

Description

Python3-libtorrent expects port to be an integer, but we send it as a string.

Unhandled error in Deferred:
17:09:18 [CRITICAL][twisted                           :154 ] Unhandled error in Deferred:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 1630, in main
    return _Gtk_main(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/deluge/ui/gtk3/peers_tab.py", line 392, in on_menuitem_add_peer_activate
    client.core.connect_peer(self.torrent_id, ip, port)
  File "/usr/lib/python3/dist-packages/deluge/ui/client.py", line 551, in __call__
    return self.daemon.call(self.base, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/deluge/ui/client.py", line 500, in call
    return defer.maybeDeferred(m, *copy.deepcopy(args), **copy.deepcopy(kwargs))
--- <exception caught here> ---
  File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", line 151, in maybeDeferred
    result = f(*args, **kw)
  File "/usr/lib/python3/dist-packages/deluge/core/core.py", line 684, in connect_peer
    if not self.torrentmanager[torrent_id].connect_peer(ip, port):
  File "/usr/lib/python3/dist-packages/deluge/core/torrent.py", line 1211, in connect_peer
    self.handle.connect_peer((peer_ip, peer_port), 0)
builtins.TypeError: No registered converter was able to produce a C++ rvalue of type int from this Python object of type str

Change History (1)

comment:1 Changed 3 years ago by Cas

  • Resolution set to Fixed
  • Status changed from new to closed

Fixed: [62d8749e74]

Note: See TracTickets for help on using tickets.